Skip to content

Conversation

@DrewScoggins
Copy link
Member

This updates the servicing branches to use the new Ubuntu 22.04 queues.

Customer Impact

None, as this does not change product code.

Regression?

No.

Testing

Currently running on main branches successfully

Risk

Low. This is not a product change, and as such I expect the risk to be zero.

cincuranet and others added 3 commits August 17, 2023 11:20
* Because crossgen need LTTng and 22.04 is not compatible.
* Windows using same queue.
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This updates the servicing branches to use the new Ubuntu 22.04 queues.

Customer Impact

None, as this does not change product code.

Regression?

No.

Testing

Currently running on main branches successfully

Risk

Low. This is not a product change, and as such I expect the risk to be zero.

Author: DrewScoggins
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve. we should consider this tell mode. adding @carlossanlop to assist on when we can merge.

@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This updates the servicing branches to use the new Ubuntu 22.04 queues.

Customer Impact

None, as this does not change product code.

Regression?

No.

Testing

Currently running on main branches successfully

Risk

Low. This is not a product change, and as such I expect the risk to be zero.

Author: DrewScoggins
Assignees: DrewScoggins
Labels:

Servicing-approved, area-Infrastructure

Milestone: -

@carlossanlop
Copy link
Contributor

carlossanlop commented Aug 17, 2023

The release/7.0 branch is currently closed. Is it ok if we wait until the branches open again next month so that your same change which was merged into release/7.0-staging is flowed into the release/7.0 branch?

(Which means closing this PR).

@carlossanlop carlossanlop removed the Servicing-approved Approved for servicing release label Aug 17, 2023
@DrewScoggins
Copy link
Member Author

If the branch is closed, does that mean that there will be no additional check-ins until the branch opens up? If that is the case then this should be fine, as long as this goes in before other things.

@carlossanlop
Copy link
Contributor

You can merge all the changes you want into the release/7.0-staging and release/6.0-staging branches, but they will only flow once a month into release/7.0 and release/6.0 branches, when they open.

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Aug 18, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 31, 2023
@carlossanlop
Copy link
Contributor

Merging now. @DrewScoggins in the future, if you need to submit servicing PRs to the runtime repo, please target the release/7.0-staging and release/6.0-staging branches. Those are always open, and PR owners or area owners can merge them anytime.

@carlossanlop carlossanlop merged commit 45161fb into dotnet:release/7.0 Aug 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants